feat: PC-14184 Add sourceSLO field in replay config file #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrkwarcinski
changed the title
piotrkwarcinski
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
ditrytus
approved these changes
Sep 26, 2024
ditrytus
added a commit
to nobl9/sloctl
that referenced
this pull request
Oct 7, 2024
## Motivation
Run replay using an SLO as a data source.
## Summary
* Added `sourceSLO` field to replay configuration file.
```
- slo: a-prometheus-http-requests-goodtotal-ratio
project: pkw-test
from: 2024-09-12T00:00:00+02:00
sourceSLO:
slo: prometheus-http-requests-goodtotal-ratio
project: amazon-prometheus
objectivesMap:
- source: objective-1
target: objective-2
```
* All `sourceSLO` slos are added to the initial sloctl request that
checks if the user has permissions to all SLOs and if they exist.
## Related changes
* n9: nobl9/n9#15419
* nobl9-go: nobl9/nobl9-go#543
## Testing
- Added unit tests for `sourceSLO` validation in nobl9-go
## Release Notes
Replaying SLOs using file configuration now allows for replays to be run
using another SLO as a data source. This can be done by specifying the
`sourceSLO` field in a replayed SLO. The field must provide the slo
name, its project, and a mapping for objectives to match the source and
target SLO objectives.
---------
Co-authored-by: Jakub Gruszecki <jakub.gruszecki@nobl9.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Run replay using an SLO as a data source.
Summary
Added
sourceSLOstructsourceSLOwhich returns the replayStatus of the SLO that uses this SLO as a data source.Related changes
Testing
sourceSLOstruct.Release Notes
Added support for
sourceSloin Replay, allowing the specification of another SLO as a data source. The status field of an SLO now allows to return the status of the target replay for this SLO.