Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PC-13263 New kind: Reports #169

Merged
merged 8 commits into from
Aug 13, 2024
Merged

feat: PC-13263 New kind: Reports #169

merged 8 commits into from
Aug 13, 2024

Conversation

natalialanga
Copy link
Contributor

@natalialanga natalialanga commented Jul 24, 2024

Summary

Add posibility to apply/delete/get reports.

Related changes

nobl9/nobl9-go#495

Release Notes

New Report kind for handling creating, updating and deleting reports. This feature is currently in early access, and is available only on demand. If you want to utilize SDK for reports management, please reach out to Nobl9 Support.

@natalialanga natalialanga changed the title PC-13263 New kind: Reports feat: PC-13263 New kind: Reports Jul 24, 2024
@n9-machine-user n9-machine-user added enhancement New feature or request minor labels Jul 24, 2024
@nieomylnieja
Copy link
Contributor

take a look at:

If Reports are supporting labels filtering or are project scoped you will need to addd it to these lists ;)

@natalialanga
Copy link
Contributor Author

  • sloctl/internal/flags.go

Thanks! Reports do not support labels filtering and are not project scoped, so we're good.

@lukasz-dobek lukasz-dobek marked this pull request as ready for review August 6, 2024 10:49
@nieomylnieja
Copy link
Contributor

nieomylnieja commented Aug 7, 2024

you're missing sloctl tests here :)
please add them before merging this PR

These tests are located here:
https://github.com/nobl9/sloctl/tree/main/test

Sloctl tests focus on testing sloctl functionalities and not the Nobl9 API in of itself, since you're adding support for new object kind, you need to extend the following tests:

@lukasz-dobek
Copy link
Contributor

lukasz-dobek commented Aug 8, 2024

@nieomylnieja locally run e2e tests and all were successful 🎉

get.bats
...
 ✓ services
 ✓ slos
 ✓ budget adjustments
 ✓ reports
 ✓ agent
...
43 tests, 0 failures

I'd appreciate it if you could check this PR once more (hopefully the last time 😸)

@lukasz-dobek lukasz-dobek enabled auto-merge (squash) August 13, 2024 08:54
@lukasz-dobek lukasz-dobek merged commit afb7096 into main Aug 13, 2024
5 checks passed
@lukasz-dobek lukasz-dobek deleted the PC-13263-reports-kind branch August 13, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants