Allow bindings to be injected to Bleno instance #415
+16
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be awesome if it's merged :) |
|
@sandeepmistry This is effectively the only real solution for getting it to work properly on macOS. Can this be merged? |
|
@sandeepmistry Is there anything we could do to help get this change merged in? Thanks! |
|
Any way to upvote this? Bleno is effectively broken on Mac OS until this is merged! And thanks for the work, all. |
|
May I suggest to forward your changes to: https://github.com/abandonware/bleno/ Meanwhile, feedback welcome on latest release: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over in noble we can inject bindings into the
Nobleinstance (commit), so we should do the same here too.The end goal is to create native bindings (wip over at https://github.com/notjosh/bleno-mac).