Updated the scope.request event emitter to include the request body

[robballou]

I am working on a testing scenario where I am running a method that then makes several requests. In the tests, I needed to later inspect the request body, but it did not appear to include a simple way to get the request body. If there is another way to do this, no worries, but this was helpful for me.

Example:

const twitter = nock(/twitter\.com/).persist().post(/media\/upload/).reply(200);
const methods = {
  'INIT': [],
  'APPEND': [],
  'FINALIZE': [],
  'STATUS': []
};

twitter.on('request', (req, interceptor, body) => {
  const parsed = querystring.parse(body);
  if (parsed.command) {
    methods[parsed.command].push(body);
  }
});

return myMethod().then(() => {
  expect(methods.INIT).to.have.lengthOf(1);
  // ...
})

Not sure if this would be helpful (or better?) in the replied event? Essentially I wanted to spy on which interceptors had been called.

And thanks for this package, it is extremely helpful in tests! 👍

[aarongreenwald]

Hate to comment just to say +1, but this is something that I need as well. Did anyone look at this and decide whether it's something they want to merge or not? Or this PR just sitting here all alone and brokenhearted, with nobody noticing it and nobody to love it?

[gr2m]

probably the latter I’m afraid. Good news is that thanks to a sponsorship I was able to hire https://maintainer.io/ to help us turn nock into a vital project again :) stay tuned, and give us a hand if you can. #1077 is a great place to start.

I’ve rebased the PR on latest master, if CI is green I’m okay with merging the PR

[gr2m]

looking good, thanks @robballou & @aarongreenwald

[nockbot]

🎉 This PR is included in version 9.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[aarongreenwald]

@gr2m Thanks! I'm glad to hear you're able to get this going, and I'll be using it in my project. Will definitely try to report issues or submit PRs if I'm able. Thanks for developing/maintaining nock, it's a great library and helps me a ton with my testing.

[gr2m]

Thank you @aarongreenwald! if you like to help, a great place to start is #1077. It will make the test setup more reliable and hence the experience for all contributors and maintainers better moving forward. See you around :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!