Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add smoothquant OPT to examples. #1922

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Add smoothquant OPT to examples. #1922

merged 1 commit into from
Oct 27, 2023

Conversation

monorimet
Copy link
Collaborator

No description provided.

dan-garvey
dan-garvey approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@dan-garvey dan-garvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Any reason not to add a test for at least one of these model variants?

@monorimet
Copy link
Collaborator Author

Cool. Any reason not to add a test for at least one of these model variants?

Need to rework the turbine integration for models with multiple outputs (including OPT) so these will be included in that patch. Good idea!

@monorimet monorimet merged commit 9824423 into main Oct 27, 2023
3 of 6 checks passed
@monorimet monorimet deleted the ean-smoothquant branch October 27, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-garvey dan-garvey dan-garvey approved these changes

@powderluv powderluv Awaiting requested review from powderluv

@PhaneeshB PhaneeshB Awaiting requested review from PhaneeshB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monorimet @dan-garvey