-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a missing method when checking if an object is a spec-compliant FormData
object
#876
Conversation
OCD kicking in? :P |
Not exactly related to this PR, but I think we should start this discussion again 😄 class FormData extends URLSearchParams {
get [Symbol.toStringTag]() {
return "FormData";
}
} |
That would increase the size of node-fetch. And you wouldn't be able to use similar polyfills I still prefer to keep none fetch stuff outside of node-fetch. I mean formdata-node has a custom File class that is not inherit by fetch-blob and can't be a instance of the same |
@jimmywarting we have Blob already, FormData (without serialization) is almost complete in my example above and we have serialization built-in into
|
@tinovyatkin Would like @bitinn or someone else opinion on that first before we decide on it - create a issue about it first - the hasInstance is grate doe :) |
I don't think this is worth merging if #1314 gets merged. this util function got wiped out completely by |
Ah, right, #1314 seems to be very close to getting merged so lets close this one ✔️ |
MDN: https://developer.mozilla.org/en-US/docs/Web/API/FormData/has]
Spec: https://xhr.spec.whatwg.org/#dom-formdata-has