Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error when source is not exists #78

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

acyza
Copy link
Contributor

@acyza acyza commented Dec 21, 2022

compressing.zip.uncompress 的source传入undefined时既不报错也不响应

@acyza
Copy link
Contributor Author

acyza commented Dec 21, 2022

compressing.zip.uncompress返回的Promise,pipe用不了,碰到source传入undefined,null,false之类的会开启pipe模式,会导致Promise永远处于pending状态。

@fengmk2 fengmk2 changed the title 修复 compressing.zip.uncompress 的source传入undefined时既不报错也不响应 fix: throw error when source is undefined or null Dec 22, 2022
@fengmk2 fengmk2 changed the title fix: throw error when source is undefined or null fix: throw error when source is not exists Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #78 (351daea) into master (fc3a98b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   96.58%   96.61%   +0.02%     
==========================================
  Files          19       19              
  Lines         586      590       +4     
  Branches      110      111       +1     
==========================================
+ Hits          566      570       +4     
  Misses         20       20              
Impacted Files Coverage Δ
lib/utils.js 97.29% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fengmk2 fengmk2 merged commit 7785c72 into node-modules:master Dec 22, 2022
@fengmk2 fengmk2 added the bug label Dec 22, 2022
fengmk2 pushed a commit that referenced this pull request Dec 22, 2022
[skip ci]

## [1.6.3](v1.6.2...v1.6.3) (2022-12-22)

### Bug Fixes

* throw error when source is not exists ([#78](#78)) ([7785c72](7785c72))
@github-actions
Copy link

🎉 This PR is included in version 1.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants