fix: GetStreamResult.stream should be alway return Readable instance #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
commented
Dec 29, 2022
| @@ -152,8 +152,7 @@ export interface GetStreamOptions { | |||
| } | |||
|
|
|||
| export interface GetStreamResult { | |||
| /** readable stream instance if response status is not 200, stream will be null. */ | |||
There was a problem hiding this comment.
这个注释是错误的，如果是非 200 状态，这个接口会 throw error。
fengmk2
pushed a commit
that referenced
this pull request
Dec 29, 2022
[skip ci] ## [1.1.1](v1.1.0...v1.1.1) (2022-12-29) ### Bug Fixes * GetStreamResult.stream should be alway return Readable instance ([#4](#4)) ([a9b4413](a9b4413))
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.