feat: singleMode for default, and clusterMode in Egg.js #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gxcsoccer
commented
Mar 26, 2019
| @@ -29,6 +29,7 @@ class ZookeeperAPIClient extends APIClientBase { | |||
| } | |||
| get clusterOptions() { | |||
| return { | |||
| singleMode: true, | |||
There was a problem hiding this comment.
默认是单进程，在 Egg.js 里来判断是否开启多进程模式。
因为其实我们对 cluster 模式是有要求的（进程要对等），如果默认多进程模式的话可能会引起一些奇怪的咨询问题
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 94.31% 94.31%
=======================================
Files 4 4
Lines 264 264
=======================================
Hits 249 249
Misses 15 15
Continue to review full report at Codecov.
|
fengmk2
approved these changes
Mar 26, 2019
|
@gxcsoccer breaking change 么？ |
@fengmk2 嗯，算 breaking 了，发大版本吧 |
|
@gxcsoccer 好，你直接发 major 吧。 |
|
3.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.