Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12 added registeredRoutes() to return all static and dynamic routes #13

Closed
wants to merge 2 commits into from

Conversation

jdiehl
Copy link

@jdiehl jdiehl commented Oct 20, 2018

No description provided.

@coveralls
Copy link

coveralls commented Oct 20, 2018

Pull Request Test Coverage Report for Build 73

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 95.853%

Totals Coverage Status
Change from base Build 70: 0.06%
Covered Lines: 415
Relevant Lines: 425

💛 - Coveralls

@amitguptagwl
Copy link
Member

Have you tested it against versioned URLs?
I was wondering if we should return a formatted list in form of URL tree so the result can be understood by the users.
A handler may decide to log the formatted list of all registered routes, but printing handler may reveal secure code as well.

@jdiehl
Copy link
Author

jdiehl commented Oct 21, 2018

The method returns all dynamic and static routes as an unordered list with all properties of the routes included. Hopefully this will provide a good start to start building additional features, such as the suggested url tree or special handling of versions.

@amitguptagwl
Copy link
Member

.. this will provide a good start to start building additional features ..

I'm sorry but a PR is expected not to be just an enabler for other features. We're strict on the policy of "Design for future, Code for current".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants