Create shorthand methods for every HTTP method #1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitguptagwl
requested changes
Jun 26, 2018
src/letsRoute.js
Outdated
| this.on("POST",url,fn); | ||
| } | ||
| /** | ||
| * Adds routes for GET method and URL |
There was a problem hiding this comment.
It should be changed to DELETE
|
Congratulations and thanks for your first PR. |
|
Thanks a lot, you're doing a great job. |
|
Now as you're already have confidence to raise PRs, you should increase the level of complexity with each PR to learn more. |
|
Sure, I want to do that already. Can you point me to some other issue? I want to work on some more. |
|
तुम्हारा determination काबिल-ए-तारीफ है । (It looks a bit odd to write in Hindi but I'm trying to bring it in trend) I've just added an easy one in this repo. And some complex issues can be found here |
|
Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the shorthand methods and some tests for them. Please let me know if anything else is required.