Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove changelog #1000

Merged
merged 3 commits into from
Oct 26, 2017
Merged

remove changelog #1000

merged 3 commits into from
Oct 26, 2017

Conversation

gr2m
Copy link
Member

@gr2m gr2m commented Oct 20, 2017

I documented the commit conventions for semantic-release. Let me know if you have any questions @ierceg @paulmelnikow

semantic-release automatically creates releases on GitHub and puts in changelogs, see https://github.com/node-nock/nock/releases

@gr2m gr2m mentioned this pull request Oct 21, 2017
README.md Outdated
```
$ npm run changelog
```
- Commit bug fixes with `fix: ...` or `fix(scope): ...` prefix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the prefix be applied to the subject line?

README.md Outdated
$ npm run changelog
```
- Commit bug fixes with `fix: ...` or `fix(scope): ...` prefix
- Commit new features with `feat: ...` or `feat(scope): ...` prefix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be an example of a scope for this project?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example would be nockback or recorder, different modules. I also use the scope for chores like chore(gitignore): new-ingored-file or docs like docs(README): add section xyz

@paulmelnikow
Copy link
Member

@gr2m Think we could turn off coveralls comment posting? They're mostly noise and very chatty. The result that shows up in the "checks" seems sufficient!

@gr2m
Copy link
Member Author

gr2m commented Oct 22, 2017

I heartily agree, I turn it off on all my projects.

@nock nock deleted a comment from coveralls Oct 26, 2017
@nock nock deleted a comment from coveralls Oct 26, 2017
@nock nock deleted a comment from coveralls Oct 26, 2017
@nock nock deleted a comment from coveralls Oct 26, 2017
@gr2m gr2m merged commit 7d02b1e into master Oct 26, 2017
@nock nock deleted a comment from coveralls Oct 26, 2017
@gr2m gr2m deleted the remove-changelog branch February 21, 2018 20:07
@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants