Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
TBH, lot of questionable stuff but I made changed a few simple things where it made sense. But as a whole I have a lot of questions on what this package is actually...doing. Would like to create a future item or discussion on how we can make this middleware even better.
But for the time being, yes see the code changes. Uses ES6 stuff; pointing arrow functions, class, await/async and more.
Let me know what y'all think 😃
Oh yeah and all unit tests pass and bluebird is removed (though technically it's still present since
node-oauth/node-oauth2-server
is a dependency of this...(which has bluebird))