Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBE node - let topic handling be optional #751

Merged
merged 5 commits into from
Feb 26, 2021
Merged

Conversation

dceejay
Copy link
Member

@dceejay dceejay commented Feb 1, 2021

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Adds a checkbox (on by default) - to handle msgs with msg.topic set as different streams - thais has always been the default - but some users find it confusing - so this allows them to turn it off and test every message as part of the same test.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

Dave Conway-Jones added 2 commits January 29, 2021 16:53
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 49.146% when pulling 6f38207 on rbe-topic-optional into 77fac03 on master.

@dceejay dceejay merged commit 9db89f3 into master Feb 26, 2021
@dceejay dceejay deleted the rbe-topic-optional branch July 11, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants