Refact: Separate LED selection and state control #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks good to me on first sight but can you be more precise in the description, namely:
|
|
Oh, there might be the desire of reviewers who lack context to have a subject line that sets its to hardware/intel and the IOT2050 device. |
AsuraZeng
force-pushed
the
chao/refact-gpio-led
branch
from
11d119f
to
fd732ad
Compare
Has already polished the commit message. |
BaochengSu
reviewed
Oct 21, 2022
BaochengSu
reviewed
Oct 21, 2022
AsuraZeng
force-pushed
the
chao/refact-gpio-led
branch
from
fd732ad
to
fc1f402
Compare
Separation of class LED selection and state control.
The label of the LED corresponds to the silk screen of the iot2050.
Before we use one list to enumerate all the led and its state.
like: User1 Led Red User1 Led Green User1 Led Orange
User2 Led Red User2 Led Green User2 Led Orange
if we need to add or delete the LED, we should change this list
After Separation of class LED selection and state control
one is Led selection: USER1 USER2
the other is status selection: Green Red Orange
For this structure, if the led or status changes, We don't need
to enumerate all the states.
Also there is a problem with the old version:
When we use one node to control led show green, then we use another node to control
led show red. The result we expect is led red, but the actually result is led orange.
This is caused the previous green do not turn off. State change is wrong.
This refact would also fix it.
Signed-off-by: chao zeng <chao.zeng@siemens.com>
AsuraZeng
force-pushed
the
chao/refact-gpio-led
branch
from
fc1f402
to
4812ad4
Compare
|
please comment when this has been tested and is ready to merge. |
hi |
|
Looks good to me. |
|
Thanks - published as v0.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separation of class LED selection and state control. The label of the LED corresponds to the silk screen of the iot2050.
There is a problem with the state switching of the old version, This refact would also fix it.
Signed-off-by: chao zeng chao.zeng@siemens.com
Proposed changes
Checklist
gruntto verify the unit tests pass