Improvements

README.md

@@ -78,18 +78,20 @@ passport.use(new MultiSamlStrategy(
 The profile object referenced above contains the following:
 
 ```typescript
-interface Profile {
+type Profile = {
   issuer?: string;
   sessionIndex?: string;
   nameID?: string;
   nameIDFormat?: string;
   nameQualifier?: string;
   spNameQualifier?: string;
-  mail?: string;
-  email?: string;
-  getAssertionXml(): string;
-  getAssertion(): object;
+  mail?: string;  // InCommon Attribute urn:oid:0.9.2342.19200300.100.1.3
+  email?: string;  // `mail` if not present in the assertion
+  getAssertionXml(): string;  // get the raw assertion XML
+  getAssertion(): object;  // get the assertion XML parsed as a JavaScript object
   ID?: string;
+} & {
+  [attributeName: string]: string;  // arbitrary `AttributeValue`s
 }
 ```
 

lib/passport-saml/saml.js

@@ -860,7 +860,8 @@ SAML.prototype.processValidlySignedAssertion = function(xml, inResponseTo, callb
     }
 
     if (!profile.mail && profile['urn:oid:0.9.2342.19200300.100.1.3']) {
-      // See http://www.incommonfederation.org/attributesummary.html for definition of attribute OIDs
+      // See https://spaces.internet2.edu/display/InCFederation/Supported+Attribute+Summary
+      // for definition of attribute OIDs
       profile.mail = profile['urn:oid:0.9.2342.19200300.100.1.3'];
     }