Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated passport package dependency #110

Closed
wants to merge 1 commit into from
Closed

Updated passport package dependency #110

wants to merge 1 commit into from

Conversation

dbck
Copy link

@dbck dbck commented Sep 7, 2015

@ploer
Copy link
Contributor

ploer commented Sep 8, 2015

Thanks for the PR. Based on reading that thread though, it sounds like the real recommendation is actually to depend on passport-strategy instead of passport directly. I'll make that change. Let me know if I'm missing something!

@ploer ploer closed this Sep 8, 2015
ploer added a commit that referenced this pull request Sep 8, 2015
@ploer
Replace passport dependency with passport-saml dependency (as suggest…
010f2d4 
…ed in PR #110)
@dbck
Copy link
Author

dbck commented Sep 8, 2015

You're right. Changing the dependency to passport-strategy will be the better solution in the long term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbck @ploer