Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default for digest algorithm #406

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

cjbarth
Copy link
Contributor

@cjbarth cjbarth commented Oct 18, 2023

This removes the default digest algorithm forcing the consumer to choose the one that they want. This is an attempt to address #376.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #406 (c93853e) into master (5629be4) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   73.91%   73.71%   -0.20%     
==========================================
  Files           9        9              
  Lines         897      898       +1     
  Branches      238      238              
==========================================
- Hits          663      662       -1     
- Misses        139      140       +1     
- Partials       95       96       +1     
Files Coverage Δ
src/signed-xml.ts 75.52% <0.00%> (-0.42%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjbarth cjbarth merged commit b6cc9c0 into node-saml:master Oct 19, 2023
7 of 9 checks passed
@cjbarth cjbarth deleted the digest-default branch October 19, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants