Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/ folder should be documented #83

Closed
shakty opened this issue Jun 10, 2019 · 3 comments
Closed

lib/ folder should be documented #83

shakty opened this issue Jun 10, 2019 · 3 comments

Comments

@shakty
Copy link
Member

shakty commented Jun 10, 2019

Otherwise if a game has a lib/ folder in public/ might be shadowed if the game is run as default channel

@shakty shakty added the doc label Jun 10, 2019
@MarcCote
Copy link

I think the problem I got is because in bootstrap.min.css shipped with nodegame-server there are a few hardcoded URLs (see https://github.com/nodeGame/nodegame-server/blob/b2b6d9052fb265ea50b657337914aac3e0148e0d/public/lib/bootstrap/bootstrap.css#L2278).

It seems the fonts folder is not shipped with nodegame-server, though.

The error I got on the server side:

Error: ENOENT: no such file or directory, stat '/data/src/nodegame/node_modules/nodegame-server/public/lib/fonts/glyphicons-halflings-regular.woff'
Error: ENOENT: no such file or directory, stat '/data/src/nodegame/node_modules/nodegame-server/public/lib/fonts/glyphicons-halflings-regular.ttf'

@shakty
Copy link
Member Author

shakty commented Jun 12, 2019

You are right. Bootstrap is currently not shipped using the standard dist/ folder in the bootstrap repo. This needs to be patched asap. For now, I think that copying the fonts folder:

https://github.com/twbs/bootstrap/tree/v3-dev/dist/fonts

inside

node_modules/nodegame-server/public/lib/

should work.

However, the final solution will probably involve reproducing the dist/ folder inside the current bootstrap folder.

@shakty
Copy link
Member Author

shakty commented Aug 21, 2020

Added to doc

@shakty shakty closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants