Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pako won't work in ie8 #46

Closed
avivgiladi opened this issue Jan 6, 2015 · 9 comments
Closed

Pako won't work in ie8 #46

avivgiladi opened this issue Jan 6, 2015 · 9 comments

Comments

@avivgiladi
Copy link

When I try to deflate a simple object (copied it from the example) it return empty string. When I try it in new browsers it works just fine. This are the lines.

var test = { my: 'super', puper: [456, 567], awesome: 'pako' };

var binaryString = pako.deflate(JSON.stringify(test), { to: 'string' }

@puzrin
Copy link
Member

puzrin commented Jan 6, 2015

Did you loaded es5-shim (and may be es5-sham) ? Pako should work in IE8.

@avivgiladi
Copy link
Author

Thanks for the response.
I didn't. must I use it? if so, should I just load it?
i'm using pako for js (not node).

On Tue, Jan 6, 2015 at 6:24 PM, Vitaly Puzrin notifications@github.com
wrote:

Did you loaded es5-shim https://github.com/es-shims/es5-shim (and may
be es5-sham) ? Pako should work in IE8.


Reply to this email directly or view it on GitHub
#46 (comment).

Aviv Giladi
Developer
BioCatch,
+972-54-5229229

@puzrin
Copy link
Member

puzrin commented Jan 6, 2015

Currently nobody writes in es3, all prefer to use ecmascript 5 at least. es5 polyfills are essential things for all who care about ancient browsers support. If you need to run code in < IE9, you must load es5-shim/sham regardless of package you use.

@puzrin
Copy link
Member

puzrin commented Jan 6, 2015

https://stuk.github.io/jszip/ see browsers support, jszip uses pako under the hood

@avivgiladi
Copy link
Author

Thanks. Somehow still with this library deflate won't work for me. When I
use another library for deflating it works just fine in ie8.

On Tue, Jan 6, 2015 at 6:41 PM, Vitaly Puzrin notifications@github.com
wrote:

https://stuk.github.io/jszip/ see browsers support, jszip uses pako under
the hood


Reply to this email directly or view it on GitHub
#46 (comment).

Aviv Giladi
Developer
BioCatch,
+972-54-5229229

@puzrin
Copy link
Member

puzrin commented Jan 6, 2015

No problem.

@puzrin puzrin closed this as completed Jan 6, 2015
@avivgiladi
Copy link
Author

It still not working... even with this libraries

@puzrin
Copy link
Member

puzrin commented Jan 6, 2015

I beleive, but i have not enougth info to help, and no ie8 to debug, sorry. Try to create test repo with example (with all necessary files to open in browser), I'll take a look later.

@puzrin
Copy link
Member

puzrin commented Sep 13, 2015

https://saucelabs.com/beta/builds/e3a964f207f248b2891c503c2b94e460

pako tests are passing from IE6+ and without shims. I think, problem is not related to this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants