-
-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pako won't work in ie8 #46
Comments
Did you loaded es5-shim (and may be es5-sham) ? Pako should work in IE8. |
Thanks for the response. On Tue, Jan 6, 2015 at 6:24 PM, Vitaly Puzrin notifications@github.com
Aviv Giladi |
Currently nobody writes in es3, all prefer to use ecmascript 5 at least. es5 polyfills are essential things for all who care about ancient browsers support. If you need to run code in < IE9, you must load es5-shim/sham regardless of package you use. |
https://stuk.github.io/jszip/ see browsers support, jszip uses pako under the hood |
Thanks. Somehow still with this library deflate won't work for me. When I On Tue, Jan 6, 2015 at 6:41 PM, Vitaly Puzrin notifications@github.com
Aviv Giladi |
No problem. |
It still not working... even with this libraries |
I beleive, but i have not enougth info to help, and no ie8 to debug, sorry. Try to create test repo with example (with all necessary files to open in browser), I'll take a look later. |
https://saucelabs.com/beta/builds/e3a964f207f248b2891c503c2b94e460 pako tests are passing from IE6+ and without shims. I think, problem is not related to this library. |
When I try to deflate a simple object (copied it from the example) it return empty string. When I try it in new browsers it works just fine. This are the lines.
var test = { my: 'super', puper: [456, 567], awesome: 'pako' };
var binaryString = pako.deflate(JSON.stringify(test), { to: 'string' }
The text was updated successfully, but these errors were encountered: