fix: sortBy parameter parse error

Author: zeevenn

android/src/main/java/com/musiclibrary/tracks/GetTracksQuery.kt

@@ -185,7 +185,7 @@ object GetTracksQuery {
 
   private fun buildSortOrder(sortBy: List<String>): String {
     if (sortBy.isEmpty()) {
-      return "${MediaStore.Audio.Media.DATE_ADDED} DESC"
+      return "${MediaStore.Audio.Media.DATE_ADDED} ASC"
     }
 
     return sortBy.joinToString(", ") { sortOption ->

example/src/TrackList.tsx

@@ -59,6 +59,7 @@ export default function TrackList() {
         first: 100,
         ...options,
         after: cursor,
+        sortBy: ['artist', true],
       });
 
       allTracks = [...allTracks, ...result.items];

src/__tests__/index.test.tsx

@@ -1 +1,43 @@
-it.todo('write a test');
+import { normalizeSortBy } from '../utils';
+
+// Mock the native module
+jest.mock('../NativeMusicLibrary', () => ({}));
+
+describe('normalizeSortBy', () => {
+  it('should return empty array when input is undefined', () => {
+    expect(normalizeSortBy(undefined)).toEqual([]);
+  });
+
+  it('should handle single SortByKey', () => {
+    expect(normalizeSortBy('default')).toEqual(['default']);
+    expect(normalizeSortBy('artist')).toEqual(['artist']);
+  });
+
+  it('should handle [SortByKey, boolean] tuple', () => {
+    expect(normalizeSortBy(['default', true])).toEqual([['default', true]]);
+    expect(normalizeSortBy(['artist', false])).toEqual([['artist', false]]);
+  });
+
+  it('should handle array of SortByValue', () => {
+    expect(normalizeSortBy(['default', 'artist'])).toEqual([
+      'default',
+      'artist',
+    ]);
+    expect(
+      normalizeSortBy([
+        ['default', true],
+        ['artist', false],
+      ])
+    ).toEqual([
+      ['default', true],
+      ['artist', false],
+    ]);
+  });
+
+  it('should handle mixed array of SortByValue', () => {
+    expect(normalizeSortBy(['default', ['artist', true]])).toEqual([
+      'default',
+      ['artist', true],
+    ]);
+  });
+});

src/utils.ts

@@ -4,6 +4,7 @@ import {
   type AssetsOptions,
   type InternalAssetsOptions,
   type InternalSortByValue,
+  type SortByKey,
   type SortByValue,
 } from './NativeMusicLibrary';
 
@@ -53,6 +54,32 @@ export function getId(
   return ref ? ref.id : undefined;
 }
 
+/**
+ * Parse sortBy to SortByValue[]
+ * @param sortBy - SortByValue or SortByValue[]
+ * @returns SortByValue[]
+ */
+export function normalizeSortBy(
+  input: SortByValue | SortByValue[] | undefined
+): SortByValue[] {
+  if (!input) return [['default', true]];
+
+  // If input is an array, check if it's a SortByValue[] or [SortByKey, boolean]
+  if (Array.isArray(input)) {
+    const isTuple =
+      input.length === 2 &&
+      typeof input[0] === 'string' &&
+      typeof input[1] === 'boolean';
+    if (isTuple) {
+      return [input as [SortByKey, boolean]];
+    } else {
+      return input as SortByValue[];
+    }
+  }
+
+  return [input];
+}
+
 export function getOptions(
   assetsOptions: AssetsOptions
 ): InternalAssetsOptions {
@@ -62,7 +89,7 @@ export function getOptions(
     after: getId(after),
     first: first == null ? 20 : first,
     directory,
-    sortBy: arrayize(sortBy),
+    sortBy: normalizeSortBy(sortBy),
   };
 
   if (after != null && typeof options.after !== 'string') {