Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Commit#amendWithSignature #1616

Merged
merged 3 commits into from
Jan 29, 2019
Merged

Add Commit#amendWithSignature #1616

merged 3 commits into from
Jan 29, 2019

Conversation

emmax86
Copy link
Collaborator

@emmax86 emmax86 commented Jan 28, 2019

This change adds signing capabilities for amending commits.

@emmax86 emmax86 force-pushed the feature/amend-with-signature branch from f8ff268 to 61a20de Compare January 28, 2019 20:48
@emmax86 emmax86 assigned emmax86 and implausible and unassigned emmax86 Jan 28, 2019
implausible
implausible requested changes Jan 28, 2019
View reviewed changes
Copy link
Member

@implausible implausible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Just a few style concerns.

lib/commit.js Outdated Show resolved Hide resolved
lib/commit.js Outdated Show resolved Hide resolved
@implausible implausible merged commit 06632f2 into nodegit:master Jan 29, 2019
@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@implausible implausible implausible approved these changes

Assignees

@implausible implausible

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmax86 @implausible