Issue #570: Disable keep-alive if no agent. #573
Conversation
|
You would also need extremely high load to actually run out of FDs. I can hold down CTRL-R in my browser and constantly load a 404 page, and it climbs up into the ~170 range on my mac, but this is a far cry from the 10K range it will get to without this fix. |
|
@jwalton This is something I can jive with. We haven't seen issues with this currently but it does make sense as we need to tell the operating system in SOME WAY to close the FD. Have you been able to test that this still works appropriately with |
|
I can't say for sure that I did try it, so I'll try it again to be extra -Jason
|
|
Arg. Tonight I'm seeing this problem happen in node 0.10 and node 0.11, On Fri, Feb 7, 2014 at 6:12 PM, Jason Walton jason@thedreaming.org wrote:
|
|
fixes in 89a22bc |
This is an alternative fix for #570 (see my other pr #572).
The idea here is that if no agent is specified, we explicitly set keepAlive to false.
If keepAlive is true, then every time we proxy a request we will create a new connection (because there is no agent managing a pool of connections), but with keepAlive set, node.js will not kill the connection after we make a request. The connection will stay open (potentially for several minutes) eating up a file descriptor.
With keepAlive set false, node.js will close the connection for us after the request is made, cleaning up the resources immediately. Under heavy load, this will result in far more connections than in PR #572, but may or may not result in better performance overall. When heavy load clears, however, the connection count will drop back down immediately.
Note that, with or without this fix, connections are not being reused - all this does is clean up connections after we're done with them. Also not that in node v0.11.11, this option is implicitly set for us when node assigns us an agent.