Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote on primordials in error path #1158

Merged
merged 25 commits into from
Feb 23, 2022
Merged

Vote on primordials in error path #1158

Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
3864fa0
vote on primordials in the error path
aduh95 Jan 26, 2022
acbbd8b
vote from aduh95
aduh95 Jan 26, 2022
8c05246
vote from targos
targos Jan 27, 2022
62d53c6
vote from MylesBorins
MylesBorins Jan 27, 2022
4ddea50
vote from Rich Trott
Trott Jan 28, 2022
5dbb431
vote from Mary Marchini
mmarchini Jan 29, 2022
74b8ffa
vote from Matteo Collina
mcollina Jan 29, 2022
5bfb7a8
vote from Gireesh Punathil
gireeshpunathil Jan 29, 2022
4391dfc
vote from cjihrig
cjihrig Jan 29, 2022
d0ada1f
vote from jasnell
jasnell Feb 3, 2022
28fb209
vote from Michael Dawson
mhdawson Feb 3, 2022
a619c98
vote from Robert Nagy
ronag Feb 5, 2022
1466e68
vote from RaisinTen
RaisinTen Feb 5, 2022
d39d109
vote from RaisinTen
RaisinTen Feb 5, 2022
a93f03e
vote from RaisinTen
RaisinTen Feb 5, 2022
3931bcc
vote from Tobias Nießen
tniessen Feb 6, 2022
9107321
vote from richardlau
richardlau Feb 8, 2022
c3a1456
vote from richardlau
richardlau Feb 8, 2022
5a905c3
vote from Beth Griggs
BethGriggs Feb 8, 2022
ad8e96e
vote from danielleadams
danielleadams Feb 8, 2022
ff85588
Add vote from Joyee Cheung
joyeecheung Feb 10, 2022
1d393b9
vote from BridgeAR
BridgeAR Feb 12, 2022
3e99994
close vote and aggregate results
aduh95 Feb 21, 2022
3b980f9
Add missing EOL
aduh95 Feb 21, 2022
42b7c02
Add back Gireesh vote data
aduh95 Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
157 changes: 157 additions & 0 deletions votes/2022-02-21-0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,157 @@
{
"description": "Do we want to make code in the error path tamper proof (and how tamper proof do we want it to be)?",
"refs": [
"https://github.com/nodejs/TSC/pull/1158"
],
"outcome": {
"winner(s)": [
"Use primordials in the error path only if there are no significant perf regression."
]
},
"votes": {
"aduh95": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 1,
"Make the code in the error path full tamper proof by using primordials.": 2,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": -1,
"Use primordials in the error path only if there are no significant perf regression.": 0,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
"Don't use any primordials (and undo existing ones) in the error path.": -2
},
"BethGriggs": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 1,
"Make the code in the error path full tamper proof by using primordials.": 1,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 1,
"Use primordials in the error path only if there are no significant perf regression.": 3,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 3,
"Don't use any primordials (and undo existing ones) in the error path.": 3
},
"BridgeAR": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
"Make the code in the error path full tamper proof by using primordials.": 0,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
"Use primordials in the error path only if there are no significant perf regression.": 70,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 80,
"Don't use any primordials (and undo existing ones) in the error path.": 88
},
"cjihrig": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
"Make the code in the error path full tamper proof by using primordials.": 0,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
"Use primordials in the error path only if there are no significant perf regression.": 0,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
"Don't use any primordials (and undo existing ones) in the error path.": 0
},
"danielleadams": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
"Make the code in the error path full tamper proof by using primordials.": 0,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
"Use primordials in the error path only if there are no significant perf regression.": 0,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
"Don't use any primordials (and undo existing ones) in the error path.": 0
},
aduh95 marked this conversation as resolved.
Show resolved Hide resolved
"gireeshpunathil": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 5,
"Make the code in the error path full tamper proof by using primordials.": 3,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 4,
"Use primordials in the error path only if there are no significant perf regression.": 1,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 2,
"Don't use any primordials (and undo existing ones) in the error path.": 0
},
"jasnell": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": -1,
"Make the code in the error path full tamper proof by using primordials.": 0,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
"Use primordials in the error path only if there are no significant perf regression.": 0,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": -1,
"Don't use any primordials (and undo existing ones) in the error path.": -1
},
"joyeecheung": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 3,
"Make the code in the error path full tamper proof by using primordials.": 1,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
"Use primordials in the error path only if there are no significant perf regression.": 2,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 2,
"Don't use any primordials (and undo existing ones) in the error path.": 0
},
"mcollina": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
"Make the code in the error path full tamper proof by using primordials.": 2,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 1,
"Use primordials in the error path only if there are no significant perf regression.": 10,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 3,
"Don't use any primordials (and undo existing ones) in the error path.": 0
},
"mhdawson": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
"Make the code in the error path full tamper proof by using primordials.": 0,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
"Use primordials in the error path only if there are no significant perf regression.": 5,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
"Don't use any primordials (and undo existing ones) in the error path.": 4
},
"mmarchini": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
"Make the code in the error path full tamper proof by using primordials.": 0,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
"Use primordials in the error path only if there are no significant perf regression.": 0,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
"Don't use any primordials (and undo existing ones) in the error path.": 0
},
"MylesBorins": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
"Make the code in the error path full tamper proof by using primordials.": 0,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
"Use primordials in the error path only if there are no significant perf regression.": 0,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
"Don't use any primordials (and undo existing ones) in the error path.": 0
},
"RaisinTen": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
"Make the code in the error path full tamper proof by using primordials.": -1,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
"Use primordials in the error path only if there are no significant perf regression.": -1,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 1,
"Don't use any primordials (and undo existing ones) in the error path.": 1
},
"richardlau": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 2,
"Make the code in the error path full tamper proof by using primordials.": 0,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
"Use primordials in the error path only if there are no significant perf regression.": 1,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
"Don't use any primordials (and undo existing ones) in the error path.": 0
},
"ronag": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 3,
"Make the code in the error path full tamper proof by using primordials.": 0,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 1,
"Use primordials in the error path only if there are no significant perf regression.": 2,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 4,
"Don't use any primordials (and undo existing ones) in the error path.": 5
},
"targos": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
"Make the code in the error path full tamper proof by using primordials.": 3,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 3,
"Use primordials in the error path only if there are no significant perf regression.": 2,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 1,
"Don't use any primordials (and undo existing ones) in the error path.": 0
},
"tniessen": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": -1,
"Make the code in the error path full tamper proof by using primordials.": 0,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": -1,
"Use primordials in the error path only if there are no significant perf regression.": 0,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": -1,
"Don't use any primordials (and undo existing ones) in the error path.": 0
},
"Trott": {
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
"Make the code in the error path full tamper proof by using primordials.": 0,
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
"Use primordials in the error path only if there are no significant perf regression.": 0,
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
"Don't use any primordials (and undo existing ones) in the error path.": 0
}
}
}
aduh95 marked this conversation as resolved.
Show resolved Hide resolved