Moderation access #469

mhdawson · 2018-01-12T22:39:38Z

No description provided.

Trott · 2018-01-12T22:46:21Z

Can you please run this (and all doc contributions) through a spelling/grammar checker?

mhdawson · 2018-01-12T22:46:32Z

One note is that we are still moving some repos over to nodejs-private, and we should probably wait until that is done to land this (if we reach consensus). I don't think that moving them over should take more than a few days.

Trott · 2018-01-12T22:46:40Z

GitHub-Org-Management-Policy.md

+* Limiting access to reduce risk
+* Enabling individuals to move community work forward without undue delay
+
+When possible we should use automation and tools to reduce the breadth of access


add comma after possible

Probably don't want to use we here or on line 27.

mhdawson · 2018-01-12T22:46:58Z

@Trott do you have a good suggestion for one that you use when generating md files ?

Trott · 2018-01-12T22:47:27Z

GitHub-Org-Management-Policy.md

+* Enabling individuals to move community work forward without undue delay
+
+When possible we should use automation and tools to reduce the breadth of access
+that needs to be provide in order to enable individuals to move community work foward.


typo: be provide -> be provided

forward is misspelled

Trott · 2018-01-12T22:47:51Z

GitHub-Org-Management-Policy.md

+As these tools are developed and put in place we will reduce the groups to which
+org ownership is granted.
+
+At the current time the following groups are granted access in order for them


add a comma after time

Trott · 2018-01-12T22:48:02Z

GitHub-Org-Management-Policy.md

+to facilitate community work.
+
+* TSC members
+* Chair of the Community Comittee


Committee is misspelled

Trott · 2018-01-12T22:48:13Z

GitHub-Org-Management-Policy.md

+* TSC members
+* Chair of the Community Comittee
+* Moderation team members. - It is expected that moderation team members will limit
+their use of the access granted to that requied to carry out moderation across the


required is misspelled

Trott · 2018-01-12T22:52:55Z

@Trott do you have a good suggestion for one that you use when generating md files ?

I usually use the free version of Grammarly, although I don't know how well it does with raw markdown. I have a Markdown editor, so I copy/paste the rendered doc into Grammarly rather than the raw markdown. But I'd guess it's fine, especially for a doc like this. It can generate a lot of false positives, but I think that's pretty much true of all the grammar tools.

mhdawson · 2018-01-12T23:02:10Z

Pushed commit addressing initial comments.

Trott · 2018-01-13T00:04:02Z

GitHub-Org-Management-Policy.md

-TSC members and the Chair of the Community Committee are the only individuals granted
-Owner permissions within the Node.js GitHub Organization.
+As with other resources within the community, Org ownership will be
+granted in order to optimize for the conflicting requirements of:


We don't use "Org ownership" in the doc. That phrase is pretty colloquial. Stick to the terminology elsewhere: Owner permissions.

"As with other resources within the community..." is filler. Take it out.

So, all told, maybe something like this?:

Whether to grant Owner permissions is determined by optimizing for the following conflicting requirements:

(As an alternative, I'd also be all for taking out all of this explanatory material and just identifying the people that have Owner permissions.)

Trott · 2018-01-13T00:04:36Z

GitHub-Org-Management-Policy.md

+
+When possible, automation and tools should be used to reduce the breadth of
+access that needs to be provided in order to enable individuals to move
+community work forward.  As these tools are developed and put in place we will


How about this instead?:

As these tools are created, the groups to which Owner permissions are granted will be reduced.

Trott · 2018-01-13T00:05:19Z

GitHub-Org-Management-Policy.md

+community work forward.  As these tools are developed and put in place we will
+reduce the groups to which org ownership is granted.
+
+At the current time, the following groups are granted access in order for them


Nit: "At the current time" is superfluous. Take it out.

Also consider removing "in order for them to facilitate community work.". The sentence should end with a colon as well. So all told, maybe this?:

The following groups are granted Ownership permissions:

Trott · 2018-01-13T00:06:18Z

GitHub-Org-Management-Policy.md

+
+* TSC members
+* Chair of the Community Committee
+* Moderation team members. - It is expected that moderation team members


Nit: remove the dash/hyphen/whatever.

Nit: Get rid of "It is expected that".

Generally, I think we've been styling it captialized in the docs: Moderation Team

Trott · 2018-01-13T00:57:31Z

The TL;DR of this seems to be "Moderation Team gets Owner permissions until there's some other way for them to do their work, which will hopefully be a bot at some point in the not-too-distant future."

+1 from me!

mcollina

LGTM

jasnell · 2018-01-16T16:20:39Z

Given the objections that @rvagg has raised on this, I'd like for this to to on the tsc-agenda for discussion before it lands. I'm not -1'ing the actual change, I just want it to be discussed on the call.

jasnell

Temporarily -1'ing to ensure that there is adequate discussion on the tsc call before this lands

mhdawson · 2018-01-18T18:26:51Z

Was discussed in last TSC meeting, no objections to moving forward. James said we could dismiss his objection.

James agreed we could dismiss in last TSC review.

jasnell · 2018-01-18T18:31:34Z

Also from the TSC meeting: Everyone with owner access needs to have 2FA enabled on their github account. That needs to be confirmed before assigning the owner permission. Also, efforts to pursue automation options need to move forward so that assigning owner permissions to individuals outside the TSC and CommComm chairs no longer becomes necessary. The rationale there is strictly limited to general security concerns -- that is, the higher the number of users with owner permissions, the higher the risk of something bad happening should one of those accounts be compromised. So granting owner permissions to the moderation team should be considered a temporary action until an automated solution can be developed.

mhdawson · 2018-01-18T18:32:27Z

@Trott took the action to validate 2FA before adding owner access.

jasnell · 2018-01-18T18:36:39Z

took the action to validate 2FA before adding owner access

Yep... for existing mod team members... it needs to be confirmed for new members before assigning permissions.

PR-URL: #469 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: MichaëZasso <targos@protonmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

mhdawson · 2018-01-18T20:02:51Z

Landed as 9cf274c

doc: Extend org ownership to moderation team

ba2bda8

mhdawson force-pushed the moderation-access branch from 03741cb to ba2bda8 Compare January 12, 2018 22:42

mhdawson mentioned this pull request Jan 12, 2018

GitHub Owner permissions nodejs/admin#33

Closed

Trott reviewed Jan 12, 2018

View reviewed changes

squash: address comments

daaa07f

mhdawson force-pushed the moderation-access branch from eb4558d to daaa07f Compare January 12, 2018 23:01

Trott reviewed Jan 13, 2018

View reviewed changes

mcollina approved these changes Jan 13, 2018

View reviewed changes

addaleax approved these changes Jan 13, 2018

View reviewed changes

squash: address comments

670b6f2

mhdawson added the tsc-review label Jan 15, 2018

targos approved these changes Jan 15, 2018

View reviewed changes

thefourtheye approved these changes Jan 16, 2018

View reviewed changes

jasnell previously requested changes Jan 16, 2018

View reviewed changes

jasnell added tsc-agenda and removed tsc-review labels Jan 16, 2018

mhdawson mentioned this pull request Jan 16, 2018

Node.js Foundation Technical Steering Committee (TSC) Meeting 2018-01-17 #471

Closed

Trott removed the tsc-agenda label Jan 17, 2018

mhdawson closed this Jan 18, 2018

mhdawson deleted the moderation-access branch August 14, 2019 17:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Moderation access #469

Moderation access #469

mhdawson commented Jan 12, 2018

Trott commented Jan 12, 2018

mhdawson commented Jan 12, 2018

Trott Jan 12, 2018

Trott Jan 12, 2018

mhdawson commented Jan 12, 2018 •

edited

Loading

Trott Jan 12, 2018

Trott Jan 12, 2018

Trott Jan 12, 2018

Trott Jan 12, 2018

Trott Jan 12, 2018

Trott commented Jan 12, 2018

mhdawson commented Jan 12, 2018

Trott Jan 13, 2018 •

edited

Loading

Trott Jan 13, 2018 •

edited

Loading

Trott Jan 13, 2018

Trott Jan 13, 2018

Trott Jan 13, 2018

Trott Jan 13, 2018 •

edited

Loading

Trott Jan 13, 2018

Trott commented Jan 13, 2018

mcollina left a comment

jasnell commented Jan 16, 2018 •

edited

Loading

jasnell left a comment

mhdawson commented Jan 18, 2018

jasnell commented Jan 18, 2018

mhdawson commented Jan 18, 2018

jasnell commented Jan 18, 2018

mhdawson commented Jan 18, 2018

Moderation access #469

Moderation access #469

Conversation

mhdawson commented Jan 12, 2018

Trott commented Jan 12, 2018

mhdawson commented Jan 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhdawson commented Jan 12, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Trott commented Jan 12, 2018

mhdawson commented Jan 12, 2018

Trott Jan 13, 2018 • edited Loading

Choose a reason for hiding this comment

Trott Jan 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Trott Jan 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Trott commented Jan 13, 2018

mcollina left a comment

Choose a reason for hiding this comment

jasnell commented Jan 16, 2018 • edited Loading

jasnell left a comment

Choose a reason for hiding this comment

mhdawson commented Jan 18, 2018

jasnell commented Jan 18, 2018

mhdawson commented Jan 18, 2018

jasnell commented Jan 18, 2018

mhdawson commented Jan 18, 2018

mhdawson commented Jan 12, 2018 •

edited

Loading

Trott Jan 13, 2018 •

edited

Loading

Trott Jan 13, 2018 •

edited

Loading

Trott Jan 13, 2018 •

edited

Loading

jasnell commented Jan 16, 2018 •

edited

Loading