Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: guard potentially unset parameter #3020

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

richardlau
Copy link
Member

Guard against the NODEJS_VERSION parameter not being set, which
results in parameters['NODEJS_VERSION'] being null.

Refs: https://ci.nodejs.org/job/node-compile-windows/46654/console

08:02:32 println "Node.js version: ${new String(parameters['NODEJS_VERSION'])}"
...
08:02:32 FATAL: Ambiguous method overloading for method java.lang.String#<init>.
08:02:32 Cannot resolve which method to invoke for [null] due to overlapping prototypes between:
08:02:32 	[class [B]
08:02:32 	[class [C]
08:02:32 	[class java.lang.String]
08:02:32 groovy.lang.GroovyRuntimeException: Ambiguous method overloading for method java.lang.String#<init>.
08:02:32 Cannot resolve which method to invoke for [null] due to overlapping prototypes between:
08:02:32 	[class [B]
08:02:32 	[class [C]
08:02:32 	[class java.lang.String]
08:02:32 	at groovy.lang.MetaClassImpl.doChooseMostSpecificParams(MetaClassImpl.java:3251)

Guard against the `NODEJS_VERSION` parameter not being set, which
results in `parameters['NODEJS_VERSION']` being `null`.
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit 08602b3 into nodejs:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants