chore: remove production and add shallow clone #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @richardlau |
richardlau
reviewed
May 17, 2023
richardlau
approved these changes
May 18, 2023
|
File has been manually updated on the server. |
targos
pushed a commit
to targos/nodejs-build
that referenced
this pull request
May 21, 2023
Removes the outdated/deprecated `--production` flag and adds `--prefer-online`. Make the install based on the lockfile by using `npm ci` instead of `npm install`. Also make the clone process shallow as we don't need the git history here. We make a depth of 2 as Nextra/Next.js requires that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the behaviour mentioned here: nodejs/nodejs.org#5381 as when doing Next.js builds, Next.js requires development dependencies, such as TypeScript in order to operate.
This PR removes the outdated/deprecated
--productionflag and adds--prefer-online, it also makes the install be based on the lockfile by making itnpm ciinstead ofnpm install.This PR also makes the clone process shallow as we don't need the git history here. We make a depth of 2 as Nextra/Next.js requires that.