Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypted ballot generated by the web ui doesn't contain author info #5

Closed
RaisinTen opened this issue Feb 5, 2022 · 3 comments
Closed

Comments

@RaisinTen
Copy link

The generated json contains only the following fields:

  • encryptedSecret
  • data

The author field is missing.

@aduh95
Copy link
Contributor

aduh95 commented Feb 5, 2022

FWIW we are using the git commit author, it's repeated in the JSON file for convenience but it has no implication on your vote. The web UI can't guess what is the name or the email address of the voter, so it's simpler easier to not include it.

Closing as won't fix, thanks for the report.

@aduh95 aduh95 closed this as completed Feb 5, 2022
@RaisinTen
Copy link
Author

FWIW we are using the git commit author, it's repeated in the JSON file for convenience but it has no implication on your vote.

Ah thanks, good to know.

The web UI can't guess what is the name or the email address of the voter, so it's simpler easier to not include it.

But there's a field for the author info, right?

author: undefined <undefined>

Should that be removed?

@aduh95
Copy link
Contributor

aduh95 commented Feb 5, 2022

But there's a field for the author info, right?

author: undefined <undefined>

Should that be removed?

Yes good catch. It should at least be commented out, so it's clearer that it's not a very relevant info. It's too late for this vote though, I'd rather avoid pushing non-vote commits to that PR to fix the ballot.yml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants