Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pnpm; add Next.js #1017

Open
GeoffreyBooth opened this issue Oct 21, 2023 · 4 comments · May be fixed by #1044
Open

Support pnpm; add Next.js #1017

GeoffreyBooth opened this issue Oct 21, 2023 · 4 comments · May be fixed by #1044

Comments

@GeoffreyBooth
Copy link
Member

I’d like to add Next.js to CITGM. It uses pnpm to install dependencies, and before its tests can run it needs to be built. See https://github.com/vercel/next.js/blob/canary/contributing/core/developing.md.

Can we add support for pnpm like we do for yarn? And also another flag like build: true that when set runs <npm/yarn/pnpm> run build before running <npn/yarn/pnpm> test?

cc @Ethan-Arrowood

@targos
Copy link
Member

targos commented Oct 21, 2023

pnpm: sure if someone contributes it
Build script: already possible. You can provide an array of scripts to run.

@Ethan-Arrowood
Copy link

FYI I've made relative teams aware of this internally at Vercel. I'll do my best to facilitate someone to assist with adding Next.js once pnpm is supported.

@GeoffreyBooth GeoffreyBooth changed the title Support pnpm; support build step Support pnpm; add Next.js Nov 12, 2023
@Ethan-Arrowood
Copy link

For cross reference, adding Next.js to CITGM will help deter events such as: nodejs/node#50269

styfle added a commit to styfle/citgm that referenced this issue Jan 9, 2024
@styfle styfle linked a pull request Jan 9, 2024 that will close this issue
2 tasks
@styfle
Copy link
Member

styfle commented Jan 9, 2024

I created a PR here: #1044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants