Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules failing on master with --throw-deprecation #605

Open
targos opened this issue Sep 22, 2018 · 3 comments
Open

modules failing on master with --throw-deprecation #605

targos opened this issue Sep 22, 2018 · 3 comments
Labels
meta

Comments

@targos
Copy link
Member

targos commented Sep 22, 2018

I created a project to track them: https://github.com/nodejs/citgm/projects/2
The reason is mainly the deprecation of the Buffer constructor.

Note: currently, npm itself fails to run with --throw-deprecation (nodejs/node#23013).
You can work around it by replacing pseudoRandomBytes manually in lib/node_modules/npm/node_modules/unique-slug/index.js
@mcollina
Copy link
Member

Several of those are modules that I co-maintain. I’ll work on that list.

lpinca added a commit to lpinca/node-iconv that referenced this issue Oct 9, 2018
@lpinca
Do not use the deprecated Buffer() constructor
79ff68c 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@lpinca lpinca mentioned this issue Oct 9, 2018
Closed
lpinca added a commit to lpinca/node-iconv that referenced this issue Oct 9, 2018
@lpinca
lib,test: do not use the deprecated Buffer() constructor
f1057f6 
Fixes: bnoordhuis#181
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
bnoordhuis pushed a commit to bnoordhuis/node-iconv that referenced this issue Oct 9, 2018
@lpinca @bnoordhuis
lib,test: do not use the deprecated Buffer() constructor
d8149cf 
Fixes: #181
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@lpinca lpinca mentioned this issue Oct 11, 2018
Closed
lpinca added a commit to lpinca/zeromq.js that referenced this issue Oct 11, 2018
@lpinca
Do not use the deprecated Buffer() constructor
5c0baab 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
This was referenced Oct 11, 2018
Merged
Closed
lpinca added a commit to lpinca/node-crc32-stream that referenced this issue Oct 11, 2018
@lpinca
Do not use the deprecated Buffer() constructor
52c7f32 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@lpinca lpinca mentioned this issue Oct 11, 2018
Merged
lpinca added a commit to lpinca/cheerio that referenced this issue Oct 12, 2018
@lpinca
Do not use the deprecated Buffer() constructor
3a98a85 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@lpinca lpinca mentioned this issue Oct 12, 2018
Merged
lpinca added a commit to lpinca/node-graceful-fs that referenced this issue Oct 12, 2018
@lpinca
Do not use the deprecated Buffer() constructor
087020a 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@lpinca lpinca mentioned this issue Oct 12, 2018
Closed
lpinca added a commit to lpinca/JSONStream that referenced this issue Oct 13, 2018
@lpinca
Do not use the deprecated Buffer() constructor
26370f5 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
This was referenced Oct 13, 2018
Merged
Closed
lpinca added a commit to lpinca/sax-js that referenced this issue Oct 13, 2018
@lpinca
Do not use the deprecated Buffer() constructor
dc41a3a 
Fixes: isaacs#240
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@lpinca lpinca mentioned this issue Oct 13, 2018
Open
lpinca added a commit to lpinca/dicer that referenced this issue Oct 13, 2018
@lpinca
Do not use the deprecated Buffer() constructor
3a0b8b4 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@lpinca lpinca mentioned this issue Oct 13, 2018
Closed
lpinca added a commit to lpinca/sax-js that referenced this issue Oct 13, 2018
@lpinca
Do not use the deprecated Buffer() constructor
f4e970f 
Fixes: isaacs#240
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
lpinca added a commit to lpinca/binary-split that referenced this issue Oct 14, 2018
@lpinca
Do not use the deprecated Buffer() constructor
1dc81ec 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@lpinca lpinca mentioned this issue Oct 14, 2018
Merged
lpinca added a commit to lpinca/throughv that referenced this issue Oct 14, 2018
@lpinca
Do not use the deprecated Buffer() constructor
58b8c0f 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@lpinca lpinca mentioned this issue Oct 14, 2018
Merged
lpinca added a commit to lpinca/vinyl-fs that referenced this issue Oct 14, 2018
@lpinca
Update: Do not use the deprecated Buffer() constructor
aeadb14 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@lpinca lpinca mentioned this issue Oct 14, 2018
Closed
lpinca added a commit to lpinca/vinyl that referenced this issue Oct 15, 2018
@lpinca
Do not use the deprecated Buffer() constructor
c1d2c8e 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@lpinca lpinca mentioned this issue Oct 15, 2018
Merged
lpinca added a commit to lpinca/stylus that referenced this issue Oct 15, 2018
@lpinca
Do not use the deprecated Buffer() constructor
434e50a 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@lpinca lpinca mentioned this issue Oct 15, 2018
Closed
lpinca added a commit to lpinca/stylus that referenced this issue Oct 15, 2018
@lpinca
Do not use the deprecated Buffer() constructor
0ac42f9 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
lpinca added a commit to lpinca/UglifyJS2 that referenced this issue Oct 16, 2018
@lpinca
Do not use the deprecated Buffer() constructor
8fb77ee 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@lpinca lpinca mentioned this issue Oct 16, 2018
Closed
rgbkrk pushed a commit to zeromq/zeromq.js that referenced this issue Oct 18, 2018
@lpinca @rgbkrk
Do not use the deprecated Buffer() constructor (#285)
f70b9f0 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
mourner pushed a commit to max-mapper/binary-split that referenced this issue Oct 23, 2018
@lpinca @mourner
Do not use the deprecated Buffer() constructor (#13)
ecaf645 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
fb55 pushed a commit to cheeriojs/cheerio that referenced this issue Mar 28, 2019
@lpinca @fb55
Do not use the deprecated Buffer() constructor
bfd857f 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
lpinca added a commit to lpinca/vinyl-fs that referenced this issue Apr 20, 2019
@lpinca
Update: Do not use the deprecated Buffer() constructor
e3dd574 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@richardlau richardlau mentioned this issue May 1, 2019
Closed
@BridgeAR
Copy link
Member

BridgeAR commented May 2, 2019 •
edited
Loading

I just updated the list. It seems like multiple modules do not show up anymore but we also skipped quite a few of them. We should try to revisit the skipped ones as well and see if we can fix some of those.

There are two new deprecation that cause issues: OutgoingMessage.prototype._headers are deprecated and cause deprecation warnings in three modules: fastify, ws and shot (cc @lpinca @mcollina) and TLS Servername to IP causes problems in node-gyp (cc @richardlau @refack).

It seems like two deprecations do not cause any issues anymore which is nice (maybe more but that requires a closer look at the former entries).

Refs: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1842/#showFailuresLink

@BridgeAR BridgeAR added meta WIP Work in progress and removed WIP Work in progress labels May 2, 2019
@lpinca
Copy link
Member

lpinca commented May 2, 2019

If I remember correctly outgoingMessage._headers in ws is only used in tests. Should be trivial to fix.
I'll take a look when I can.

ferronrsmith pushed a commit to elasticsearch-dump/jsonstream that referenced this issue Mar 13, 2023
@lpinca @ferronrsmith
Do not use the deprecated Buffer() constructor
3636ee5 
Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mcollina @lpinca @targos @BridgeAR