Mark level/leveldown and eslint as flaky on AIX/s390 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint attempts to pull in the phantomjs prebuilt binary, but doesn't have an s390 version (or AIX, but it's already marked as flaky for ppc) I've added a comment to an existing issue on phantomjs ariya/phantomjs#13973 to see what would be required to produce a binary, but marking it flaky until this might be resolved.
leveldown is a pre-req of level which is the reason these modules are both affected. It should attempt to build from source if a prebuild doesn't exist, but this falls over as it doesn't know what to do with an OS of "AIX", and the s390 platform fails the compilation with a "Please implement AtomicPointer for this platform." comment, so marking flaky on these two platforms, having opened an issue on level down Level/leveldown#306
I've tested my changes on our test 390/aix machines, and all is working ok.