Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: add import-in-the-middle #953

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

bengl
Copy link
Member

@bengl bengl commented Jun 8, 2023

Ref: nodejs/TSC#1397

I believe all the requirements are met. The module has 1,778,787 weekly downloads on npm and uses loaders, which AFAIK no others in lookup.json do.

Checklist
  • contribution guidelines followed
    here

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.18 🎉

Comparison is base (dd3b422) 96.27% compared to head (992cdb0) 96.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
+ Coverage   96.27%   96.46%   +0.18%     
==========================================
  Files          28       28              
  Lines        2149     2149              
==========================================
+ Hits         2069     2073       +4     
+ Misses         80       76       -4     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@targos
Copy link
Member

targos commented Jun 9, 2023

Here's a first test run: https://github.com/nodejs/citgm/actions/runs/5219659418

@targos
Copy link
Member

targos commented Jun 9, 2023

Should we skip on Windows? It looks like the tests cannot be run on that platform

@bengl
Copy link
Member Author

bengl commented Jun 9, 2023

@targos that's odd. AFAICT it passes on Windows in import-in-the-middle's CI. https://github.com/DataDog/import-in-the-middle/actions/runs/5218109352

@richardlau
Copy link
Member

@targos that's odd. AFAICT it passes on Windows in import-in-the-middle's CI. https://github.com/DataDog/import-in-the-middle/actions/runs/5218109352

That's running a different npm script (test-win) for Windows. I'm not sure we have the ability in CITGM to invoke different scripts on a per-platform basis.

@bengl
Copy link
Member Author

bengl commented Jun 11, 2023

@targos @richardlau I've published import-in-the-middle@1.4.1 which no longer has a windows-specific test command, so npm test ought to work everywhere now.

@bengl
Copy link
Member Author

bengl commented Jun 11, 2023

For whatever reason it still seems to fail with citgm, despite passing in import-in-the-middle's CI on Windows. I added "skip": "win32" for now, but I can take another shot at removing that at a future date (and a future PR).

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member

targos commented Jun 13, 2023

Windows tests are known to be flaky: #930

@targos targos merged commit 460c3a0 into nodejs:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants