-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lookup: add import-in-the-middle #953
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
==========================================
+ Coverage 96.27% 96.46% +0.18%
==========================================
Files 28 28
Lines 2149 2149
==========================================
+ Hits 2069 2073 +4
+ Misses 80 76 -4 ☔ View full report in Codecov by Sentry. |
Here's a first test run: https://github.com/nodejs/citgm/actions/runs/5219659418 |
Should we skip on Windows? It looks like the tests cannot be run on that platform |
@targos that's odd. AFAICT it passes on Windows in |
That's running a different npm script ( |
@targos @richardlau I've published |
For whatever reason it still seems to fail with citgm, despite passing in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Windows tests are known to be flaky: #930 |
Ref: nodejs/TSC#1397
I believe all the requirements are met. The module has 1,778,787 weekly downloads on npm and uses loaders, which AFAIK no others in
lookup.json
do.Checklist
here