Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subsystem: allow gyp as a subsystem #65

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Conversation

sam-github
Copy link
Contributor

gyp: has been used as subsystem tag 30 times for tools/gyp

See nodejs/node#28573

`gyp:` has been used as subsystem tag 30 times for tools/gyp
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files          13       13           
  Lines         208      208           
=======================================
  Hits          204      204           
  Misses          4        4
Impacted Files Coverage Δ
lib/rules/subsystem.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3a5b2b...7450dc9. Read the comment docs.

@joyeecheung joyeecheung merged commit 5740678 into master Jul 8, 2019
@sam-github
Copy link
Contributor Author

sweet, thanks @joyeecheung

@sam-github sam-github deleted the add-gyp-subsystem branch July 8, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants