Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid quoting cflag name and parameter with space separator #223

Merged
merged 4 commits into from
Mar 7, 2024
Merged

fix: avoid quoting cflag name and parameter with space separator #223

merged 4 commits into from
Mar 7, 2024

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Mar 1, 2024 •
edited
Loading

Fixes: nodejs/node-gyp#2858

Avoid quoting -arch arm64 in generated compile_commands.json as c++ "-arch arm64".

@legendecas legendecas marked this pull request as ready for review March 1, 2024 07:21
@legendecas
Copy link
Member Author

@nodejs/gyp I'd appreciate it if this could have a review, thank you!

cclauss
cclauss requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding tests that fail without these changes but pass with these changes so that we can avoid future regressions.

cclauss
cclauss approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Perhaps create a DRAFT PR with only the test changes to prove that the tests fail on the unmodified code

@legendecas legendecas mentioned this pull request Mar 7, 2024
Closed
@legendecas
Copy link
Member Author

Sure, #224

@cclauss cclauss merged commit 2b9703d into nodejs:main Mar 7, 2024
20 checks passed
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
Merged
@legendecas legendecas deleted the compile_commands_macos branch March 7, 2024 10:32
@legendecas legendecas mentioned this pull request Mar 7, 2024
Merged
@github-actions github-actions bot mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clangd complains for Unknown argument: '-arch arm64' [drv_unknown_argument]
2 participants
@legendecas @cclauss