Update Node.js in workflows and fix release-please config #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
targos
commented
Mar 7, 2024
targos
commented
- chore: use Node.js 20 for node-gyp integration tests
- chore: fix release-please config
|
Rebased to use the pinned Ruff version. |
cclauss
reviewed
Mar 7, 2024
| release-type: python | ||
| package-name: gyp-next | ||
| bump-minor-pre-major: true | ||
| config-file: release-please-config.json |
There was a problem hiding this comment.
Why is it useful to put the release context in two separate files?
There was a problem hiding this comment.
It's not useful, we have no choice as it's mandatory since the version 4 of the action.
There was a problem hiding this comment.
You could also remove this option since that is also the default.
cclauss
approved these changes
Mar 7, 2024
|
Mmh, it wasn't obvious from the docs that both file must be there. I'll have a closer look. |
|
We just did the same upgrade in {
".": "0.16.2"
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.