Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support language standard keys in msvs_settings #252

Merged
merged 1 commit into from
May 8, 2024

Conversation

targos
Copy link
Member

@targos targos commented May 7, 2024

@lemire
Copy link
Member

lemire commented May 7, 2024

Let us clean the Windows build settings, making them less hackish. :-)

Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos targos merged commit 322f6d5 into nodejs:main May 8, 2024
25 checks passed
@targos targos deleted the language-standard branch May 8, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants