This repository has been archived by the owner on Nov 6, 2022. It is now read-only.
Add http_parser_parse_url(). #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't reviewed the code, but this is exactly what I asked in #56, so consider this an upvote. |
Closed
|
I updated the API slightly to allow using this with CONNECT : "url"s. If nobody has any objections, I'll merge this this weekend. |
|
This looks good to me |
| break; | ||
| } | ||
|
|
||
| /* We should never fall out of the swtich above unless there's an error */ |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM. |
- Add an http_parser_parse_url() method to parse a URL into its constituent components. This uses the same underlying parser as http_parser_parse() and doesn't do any data copies. - Re-add the URL components in various test.c structures; validate them when parsing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constituent components. This uses the same underlying parser
as http_parser_parse() and doesn't do any data copies.
them when parsing.