add on_reason to fix issue #59 #60
Conversation
|
For some reason I can't update this pull request to include more commits. I made 2 commits, but this is only showing 1 of them. |
|
The general idea of this seems reasonable to me, but I'd love to hear from anyone else who would find this functionality useful. If it were to actually be merged, I'd want to see updates to test.c as well. |
|
I've updated the tests to include the reason string, which helped me fix a bug. I also looked back through old issues to find people who might be using http-parser in a proxy server and sent them messages asking for feedback on the change. |
| CALLBACK(reason); | ||
| state = s_header_field_start; | ||
| break; | ||
| default: |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
This PR is pretty stale by now. Do we still want this functionality? |
|
Closing, no response in almost two weeks. |
|
FWIW- I'm another person that dug into the code to find out where that darn reason phrase was hiding. I'm wishing this functionality had made it in. Maybe you can put it on a feature request list? |
No description provided.