Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix compiler warning in smalloc.cc #1055

Closed
wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

Fix the following compiler warning by static_casting the enum values
to an uint32_t:

../src/smalloc.cc: In function 'void
node::smalloc::Initialize(v8::Handle<v8::Object>,
                          v8::Handle<v8::Value>,
                          v8::Handle<v8::Context>)':
../src/smalloc.cc:601:203: warning: enumeral and non-enumeral type
in conditional expression
    EXTERNAL_ARRAY_TYPES(V)

R=@vkurchatkin

Fix the following compiler warning by static_casting the enum values
to an uint32_t:

    ../src/smalloc.cc: In function 'void
    node::smalloc::Initialize(v8::Handle<v8::Object>,
                              v8::Handle<v8::Value>,
                              v8::Handle<v8::Context>)':
    ../src/smalloc.cc:601:203: warning: enumeral and non-enumeral type
    in conditional expression
        EXTERNAL_ARRAY_TYPES(V)
bnoordhuis added a commit that referenced this pull request Mar 4, 2015
Fix the following compiler warning by static_casting the enum values
to an uint32_t:

    ../src/smalloc.cc: In function 'void
    node::smalloc::Initialize(v8::Handle<v8::Object>,
                              v8::Handle<v8::Value>,
                              v8::Handle<v8::Context>)':
    ../src/smalloc.cc:601:203: warning: enumeral and non-enumeral type
    in conditional expression
        EXTERNAL_ARRAY_TYPES(V)

PR-URL: #1055
Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>
@vkurchatkin
Copy link
Contributor

Thanks, landed in fb284e2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants