Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

i18n for the download banner? #417

Closed
ghost opened this issue Jul 23, 2015 · 4 comments
Closed

i18n for the download banner? #417

ghost opened this issue Jul 23, 2015 · 4 comments

Comments

@ghost
Copy link

ghost commented Jul 23, 2015

Why isn't the banner content in the template.json, but hardcoded? Is it because it's a temporary addition?

@fhemberger
Copy link
Contributor

The banner was added right before the critical security fix, so we couldn't wait for i18n teams to translate it. It should only be shown for those (hopefully few) special releases, so I'm deactivating it for now.

In the long run, we might come up with a better idea for translations as well.

@ghost
Copy link
Author

ghost commented Jul 23, 2015

Yeah, that'd be nice.

@fhemberger
Copy link
Contributor

See aeb7b4c

@fhemberger
Copy link
Contributor

Closing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant