New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove semver dependency #281

Merged

ShogunPanda merged 1 commit into nodejs:main from Uzlopak:remove-semver

Jan 30, 2024

Contributor

Uzlopak commented Jan 30, 2024

replace the necessity to load semver by using a regex instead. Actually just doing

const [major, minor, patch] = pkg.version.split('.')

would have been enough. But I think the regex is better.


          remove semver dependency

e1f95a6

ShogunPanda approved these changes

View reviewed changes

Contributor

ShogunPanda left a comment

Given I don't think we're going to ever have exotic package version, I think this is already enough. Let's go!

ShogunPanda merged commit 9d58799 into nodejs:main

10 of 12 checks passed

Uzlopak deleted the remove-semver branch

January 30, 2024 08:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet