Port recent commits from http-parser #38
Conversation
I can't tell whether you are happy or sad about it from the wording 😂 |
Ported from http-parser: nodejs/http-parser@3502589
fanatid
force-pushed
the
http-parser-port
branch
from
d36f077
to
ef024c6
Compare
Ported from http-parser: nodejs/http-parser@cd88eef
fanatid
force-pushed
the
http-parser-port
branch
from
6d71487
to
d90c098
Compare
|
Not sure how port third commit, my way is super shitty and makes things more unreadable. Maybe it worth land first 2 commits and move not good solution to another PR for future? |
|
I concur! |
|
Should I submit first two in another PR or you cherry-pick them? |
PR-URL: #38 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Ported from http-parser: nodejs/http-parser@3502589 PR-URL: #38 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Ported from http-parser: nodejs/http-parser@cd88eef PR-URL: #38 Reviewed-By: Fedor Indutny <fedor@indutny.com>
|
Oh, so everything was go to master? |
|
Ooops. This wasn't my intention. Reverting! Thanks. |
|
Partially reverted in d167b03. |
|
Thanks! |
Issue #12
nodejs/http-parser@01da95f already in tests, but I moved them from
invalid.mdtocontent-length.mdnodejs/http-parser@3502589 [x] added
nodejs/http-parser@cd88eef [x] need improvements
Early feedback appreciated. Is this OK that
mdgatorrequire extra newline? For new test I was need\r\n\r\n, but withmdgatorI was able receive it only with 2 empty lines (which give 3 x\r\n, right?).Whole project (and deps) is just WOW, I do not understand how it's possible to create it haha. Spent few hours for adding simple 5 lines.