Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update headers for Mac OS X installation to pick up 3.9+ headers #75

Closed
hhellyer opened this issue Apr 12, 2017 · 5 comments
Closed

Update headers for Mac OS X installation to pick up 3.9+ headers #75

hhellyer opened this issue Apr 12, 2017 · 5 comments

Comments

@hhellyer
Copy link
Contributor

Xcode recently updated lldb on my system. Now lldb reports:
$ lldb -v
lldb-370.0.40
Swift-3.1

However this doesn't match up to the actual lldb levels so I forced the installation script to use 3.9 headers. This built and as a result I was able to run v8 findjsobjects without needing to run one of the scripts to generate memory regions.

This simplifies the usage of llnode a lot so I will update the npm install scripts. Ideally I need to find a table that maps Xcode versions to 'real' lldb releases from the lldb git repository.

@indutny
Copy link
Member

indutny commented Apr 12, 2017

Hooray!

indutny added a commit that referenced this issue Apr 19, 2017
@indutny
Copy link
Member

indutny commented Apr 19, 2017

See: Homebrew/homebrew-core#12608 . Will close this once it lands.

Thanks for update!

@hhellyer
Copy link
Contributor Author

I'll push a fix in the npm build script as well.

For reference I asked about keeping track of the lldb levels in Xcode - the response was that newer levels of lldb should be compatible with older headers. We only need to update the headers if there is a feature we need. (Which there is in this case.)

http://lists.llvm.org/pipermail/lldb-dev/2017-April/012208.html

@hhellyer
Copy link
Contributor Author

I've pushed an update to the npm script. Once this is landed I'll need to update the npm again so that Mac users installing via npm get the benefit.

@hhellyer
Copy link
Contributor Author

v1.4.3 has been published:
https://www.npmjs.com/package/llnode
I can build the plugin with npm install llnode and run findjsobjects without creating a memory ranges file on MacOS X. Closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants