Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Add features list to README #134

Merged
merged 3 commits into from
Jun 20, 2018
Merged

Conversation

GeoffreyBooth
Copy link
Member

@GeoffreyBooth GeoffreyBooth commented Jun 18, 2018

Resolves #129.

Once this is merged in, per #129 we would close all the feature issues. We can continue discussing features on those threads, but there won’t be a need to keep the GitHub issues themselves in an open state.

There are still some use cases that haven’t been discussed in any meeting, because the authors of those use cases weren’t present to explain them; so there will probably be a few more features added to this list in the future. We can also decide to cross off or remove features from this list, but I’d rather this PR not involve that discussion, if people don’t mind? This PR and commit can represent the features list as it exists today, and revisions to this list can get their own PRs and discussions in those future PRs’ threads.

Once this is merged in we can also close #55, as there would be a link to it (and its referenced Google Doc) from the README.

@GeoffreyBooth GeoffreyBooth added the modules-agenda To be discussed in a meeting label Jun 18, 2018
mhdawson

This comment was marked as off-topic.

devsnek

This comment was marked as off-topic.

benjamingr

This comment was marked as off-topic.

inidaname

This comment was marked as off-topic.

ljharb

This comment was marked as off-topic.

targos

This comment was marked as off-topic.

xtuc

This comment was marked as off-topic.

@bmeck
Copy link
Member

bmeck commented Jun 20, 2018

As long as we understand that the list of features may end up changing due to feasibility, conflicts with other features, etc. might mean crossing out some or adding others, this seems good.

bmeck

This comment was marked as off-topic.

giltayar

This comment was marked as off-topic.

MylesBorins

This comment was marked as off-topic.

@GeoffreyBooth
Copy link
Member Author

@MylesBorins I added a note that the list is subject to change. I don’t think there should be language that the features lack consensus, or that the final implementation may not achieve all of them. Since this list is subject to change, I think features that lack consensus should be removed after discussion. When we get to the point of a final implementation, if it doesn’t support some of these features we should again discuss them, and decide if those features should be supported (and therefore we keep working on the implementation) or if at that point they should be dropped.

As for the particular features that you pointed out, can we please merge this in first so that I can close all the feature issues? And then you can open another PR to suggest removing some features, and we can discuss there.

@MylesBorins
Copy link
Contributor

@GeoffreyBooth I would prefer we remove features that do not have consensus and open prs specifically to add them.

The Load ESM over https in particular is the one I would like to see removed

@GeoffreyBooth
Copy link
Member Author

@MylesBorins Updated.

MylesBorins

This comment was marked as off-topic.

@MylesBorins MylesBorins merged commit a98d607 into nodejs:master Jun 20, 2018
@GeoffreyBooth GeoffreyBooth deleted the features branch June 20, 2018 22:29
@GeoffreyBooth GeoffreyBooth removed modules-agenda To be discussed in a meeting labels May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing Feature Issues Use Cases (Tracking Issue)