Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump node-gyp to 3.0.1 #445

Merged
merged 1 commit into from
Sep 9, 2015
Merged

deps: bump node-gyp to 3.0.1 #445

merged 1 commit into from
Sep 9, 2015

Conversation

sanemat
Copy link
Contributor

@sanemat sanemat commented Sep 9, 2015

@sanemat
Copy link
Contributor Author

sanemat commented Sep 9, 2015

https://ci.appveyor.com/project/RodVagg/nan/build/985/job/ix118f3swsmrupch#L390

LINK : fatal error LNK1194: cannot delay-load 'node.exe' due to import of data symbol '"__declspec(dllimport) const v8::String::ExternalStringResource::`vftable'" (__imp_??_7ExternalStringResource@String@v8@@6B@)'; link without /DELAYLOAD:node.exe [C:\projects\nan\test\build\morenews.vcxproj]

related issue?
win: enable delay-load hook by default by Fishrock123

kkoopa added a commit that referenced this pull request Sep 9, 2015
@kkoopa
Merge pull request #445 from sanemat/chore/use-node-gyp-v3
7b98c52 
deps: bump node-gyp to 3.0.1
@kkoopa kkoopa merged commit 7b98c52 into nodejs:master Sep 9, 2015
@kkoopa
Copy link
Collaborator

kkoopa commented Sep 9, 2015

Yes, it should not use delay-load, since it does not work.

@sanemat sanemat deleted the chore/use-node-gyp-v3 branch September 9, 2015 09:16
@sanemat
Copy link
Contributor Author

sanemat commented Sep 9, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanemat @kkoopa