Skip to content

Commit 2342415

Browse files
nadonggurimhdawson
authored andcommitted
test: create test objects in the stack instead of the heap
PR-URL: #371 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
1 parent 67b7db0 commit 2342415

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

test/basic_types/boolean.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ Value CreateEmptyBoolean(const CallbackInfo& info) {
1212
}
1313

1414
Value CreateBooleanFromExistingValue(const CallbackInfo& info) {
15-
Boolean* boolean = new Boolean(info.Env(), info[0].As<Boolean>());
16-
return Boolean::New(info.Env(), boolean->Value());
15+
Boolean boolean(info.Env(), info[0].As<Boolean>());
16+
return Boolean::New(info.Env(), boolean.Value());
1717
}
1818

1919
Value CreateBooleanFromPrimitive(const CallbackInfo& info) {

test/basic_types/number.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ Value OperatorDouble(const CallbackInfo& info) {
6767
}
6868

6969
Value CreateEmptyNumber(const CallbackInfo& info) {
70-
Number* number = new Number();
71-
return Boolean::New(info.Env(), number->IsEmpty());
70+
Number number;
71+
return Boolean::New(info.Env(), number.IsEmpty());
7272
}
7373

7474
Value CreateNumberFromExistingValue(const CallbackInfo& info) {

0 commit comments

Comments
 (0)