Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme for filter conditions in unit tests #1199

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

deepakrkris
Copy link
Contributor

Document all possible filter conditions added in #1078

Document all possible filter conditions added in nodejs#1078
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @deepakrkris thanks!

@mhdawson mhdawson merged commit e9def3e into nodejs:main Aug 19, 2022
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
* Update Readme for filter conditions in unit tests

Document all possible filter conditions added in nodejs/node-addon-api#1078

PR-URL:nodejs/node-addon-api#1199
Reviewed-By: Michael Dawson <midawson@redhat.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
* Update Readme for filter conditions in unit tests

Document all possible filter conditions added in nodejs/node-addon-api#1078

PR-URL:nodejs/node-addon-api#1199
Reviewed-By: Michael Dawson <midawson@redhat.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
* Update Readme for filter conditions in unit tests

Document all possible filter conditions added in nodejs/node-addon-api#1078

PR-URL:nodejs/node-addon-api#1199
Reviewed-By: Michael Dawson <midawson@redhat.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
* Update Readme for filter conditions in unit tests

Document all possible filter conditions added in nodejs/node-addon-api#1078

PR-URL:nodejs/node-addon-api#1199
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants