Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: enforce type checks on Napi::Value::As() #1281

Merged
merged 1 commit into from
Apr 6, 2023
Merged

src: enforce type checks on Napi::Value::As() #1281

merged 1 commit into from
Apr 6, 2023

Conversation

legendecas
Copy link
Member

Fixes #1246

@legendecas legendecas mentioned this pull request Feb 3, 2023
Merged
@legendecas
Copy link
Member Author

Not sure why windows builds failed to fetch arm64 node.lib. Needs to retry after a while to see if the problem persists.

gabrielschulhof
gabrielschulhof reviewed Mar 28, 2023
View reviewed changes
doc/value.md Outdated Show resolved Hide resolved
@legendecas legendecas force-pushed the type-check branch 2 times, most recently from 1622265 to 648df97 Compare March 30, 2023 17:49
@legendecas legendecas marked this pull request as ready for review March 30, 2023 17:51
@legendecas
Copy link
Member Author

Windows tests passed! This PR is ready for review.

@mhdawson mhdawson mentioned this pull request Mar 31, 2023
Closed
mhdawson
mhdawson approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas merged commit 5adb896 into nodejs:main Apr 6, 2023
@legendecas legendecas deleted the type-check branch April 6, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielschulhof gabrielschulhof gabrielschulhof left review comments

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
SemVer-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent return value with enabled NODE_ADDON_API_ENABLE_MAYBE directive
3 participants
@legendecas @gabrielschulhof @mhdawson