Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetPropertyNames, HasOwnProperty, Delete #615

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

tniessen
Copy link
Member

Fixes: #614

@tniessen tniessen added the doc label Nov 30, 2019
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit c584343 into nodejs:master Dec 5, 2019
@tniessen tniessen deleted the fix-614 branch January 23, 2020 03:47
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
Fixes: nodejs/node-addon-api#614

PR-URL: nodejs/node-addon-api#615
Fixes: nodejs/node-addon-api#614
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
Fixes: nodejs/node-addon-api#614

PR-URL: nodejs/node-addon-api#615
Fixes: nodejs/node-addon-api#614
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
Fixes: nodejs/node-addon-api#614

PR-URL: nodejs/node-addon-api#615
Fixes: nodejs/node-addon-api#614
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
Fixes: nodejs/node-addon-api#614

PR-URL: nodejs/node-addon-api#615
Fixes: nodejs/node-addon-api#614
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] undocumented method(s) on Object.
3 participants