Add benchmarks #623
Closed
Add benchmarks #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also pretty sure it factors out the settings needed for turning on/off exceptions in an addon's binding.gyp. The except.gypi and noexcept.gypi files might be useful in and of themselves. If they are, we should add lines to index.js which gives their path for inclusion in addons. |
gabrielschulhof
force-pushed
the
add-benchmarks
branch
2 times, most recently
from
f03a98c
to
e92ef1a
Compare
gabrielschulhof
force-pushed
the
add-benchmarks
branch
from
e92ef1a
to
caf97a5
Compare
|
Alas, gyp does not support variable resolution for ...
'includes': [ '<(variable_will_not_work_here)']
... |
|
@NickNaso I linked benchmark/README.md from the main README.md. |
legendecas
approved these changes
Dec 7, 2019
|
Built products in |
gabrielschulhof
pushed a commit
that referenced
this pull request
Dec 14, 2019
Adds the framework for writing benchmarks and two basic benchmarks. PR-URL: #623 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in 6a06463. |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Adds the framework for writing benchmarks and two basic benchmarks. PR-URL: nodejs/node-addon-api#623 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Adds the framework for writing benchmarks and two basic benchmarks. PR-URL: nodejs/node-addon-api#623 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Adds the framework for writing benchmarks and two basic benchmarks. PR-URL: nodejs/node-addon-api#623 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Adds the framework for writing benchmarks and two basic benchmarks. PR-URL: nodejs/node-addon-api#623 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a benchmarking framework and two benchmarks: one for function calls and one for property descriptor getter/setter calls.